Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A6D310AA7 for ; Thu, 17 Apr 2014 14:11:35 +0000 (UTC) Received: (qmail 38174 invoked by uid 500); 17 Apr 2014 14:11:27 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 38127 invoked by uid 500); 17 Apr 2014 14:11:26 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 38061 invoked by uid 99); 17 Apr 2014 14:11:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2014 14:11:22 +0000 Date: Thu, 17 Apr 2014 14:11:22 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4909) Avoid protocol buffer RPC namespace clashes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972970#comment-13972970 ] Hudson commented on HDFS-4909: ------------------------------ SUCCESS: Integrated in Hadoop-Hdfs-trunk #1735 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1735/]) HDFS-4909. Avoid protocol buffer RPC namespace clashes (cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1588091) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/DatanodeProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/NamenodeProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/QJournalProtocol.proto > Avoid protocol buffer RPC namespace clashes > ------------------------------------------- > > Key: HDFS-4909 > URL: https://issues.apache.org/jira/browse/HDFS-4909 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode, journal-node, namenode > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: Ralph Castain > Assignee: Colin Patrick McCabe > Priority: Blocker > Fix For: 2.5.0 > > Attachments: HDFS-4909.001.patch, HDFS-4909.002.patch, pcreate.pl > > > The revised protocol buffer support seems to be compiling for me when using the protobuf-c cross-compiler. However, I still cannot construct a library of the results. This may be a Hadoop issue, or could be an issue with the protobuf-c cross-compiler. What I see are a bunch of these when attempting to link the resulting .o files: > /home/common/hadoop/hadoop-common/foo/obj/DatanodeProtocol.pb-c.o: In function `hadoop_hdfsreport_bad_blocks_request_proto_init': > DatanodeProtocol.pb-c.c.text+0x2bb4): multiple definition of `hadoop_hdfsreport_bad_blocks_request_proto_init' > /home/common/hadoop/hadoop-common/foo/obj/ClientNamenodeProtocol.pb-c.o:ClientNamenodeProtocol.pb-c.c.text+0x277d): first defined here > From what I can see, this is caused by the > package hadoop.hdfs; > line in the .proto files, when combined with the later > import "hdfs.proto"; > This appears to bring a complete copy of the hdfs.proto file into the source code, which then recompiles it - leading to the duplicate symbols. > I have attached an updated pcreate.pl script that illustrates the problem. Excluding the following .proto files allows all to be successfully built and linked: > DatanodeProtocol > ClientNamenodeProtocol > QJournalProtocol > HTH > Ralph -- This message was sent by Atlassian JIRA (v6.2#6252)