hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Lamb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6314) Test cases for XAttrs
Date Wed, 30 Apr 2014 20:15:19 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986015#comment-13986015
] 

Charles Lamb commented on HDFS-6314:
------------------------------------

FSXAttrBaseTest.java:

Add a newline before the package decl.
s/restarting NN/restarting the NN/
s/saving new/saving a new/

+   * Tests for creating xattr
+   * 1. create xattr using XAttrSetFlag.CREATE flag.
+   * 2. Assert exception of creating xattr which already exists.
+   * 3. Create multiple xattrs
+   * 4. Restart NN, save checkpoint scenarios.

Tests for creating xattrs
1. Create an xattr using XAttrSetFlag.CREATE
2. Create it again and expect an exception
3. Create multiple xattrs
4. Restart the NN in save checkpoint scenarios.

+   * Tests for replacing xattr
+   * 1. Replace xattr using XAttrSetFlag.REPLACE flag.
+   * 2. Assert exception of replacing xattr which does not exist.
+   * 3. Create multiple xattrs, and replace some.
+   * 4. Restart NN, save checkpoint scenarios.

* Tests for replacing xattrs
* 1. Replace an xattr using XAttrSetFlag.REPLACE.
* 2. Replace an xattr which doesn't exist and expect an exception
* 3. Create multiple xattrs and replace some.
* 4. Restart the NNsave in checkpoint scenarios.

s/Tests for setting xattr/Tests for setting xattrs/
s/Tests for removing xattr/Tests for removing xattrs/

I noticed that the blank lines have whitespace in them. That should be removed. e.g. the blank
line between 

+    Assert.assertArrayEquals(value2, xattrs.get(name2));
+    <------- THERE'S WHITESPACE HERE
+    fs.removeXAttr(path, name1);

> Test cases for XAttrs
> ---------------------
>
>                 Key: HDFS-6314
>                 URL: https://issues.apache.org/jira/browse/HDFS-6314
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: HDFS-6314.patch
>
>
> Tests NameNode interaction for all XAttr APIs, covers restarting NN, saving new checkpoint.
> Tests XAttr for Snapshot, symlinks.
> Tests XAttr for HA failover.
> And more...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message