hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6299) Protobuf for XAttr and client-side implementation
Date Wed, 30 Apr 2014 12:31:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985415#comment-13985415

Yi Liu commented on HDFS-6299:

Hi [~azuryy], thanks for your comment.
It should be
if (prefixIndex <= 0) {
other wise, the code will do waste before catch this Exception.

{{prefixIndex == -1}} indicates not found. The logic is name should have prefix and should
have real content after prefix. Is it the same as what you think?

It looks like you don't want to return null here? so if result is null or empty, It still
return null

Allow to return null, there is no doc says not return null.  The comment in the code 
{{//xattr exists, but no value.}} 
explains that if xattr doesn't exist, null is return, but if xattr exists with no value, empty
should return.

Another, try to use !result.isEmpty(), instead of 'result.size() > 0'
Right, {{isEmpty()}} is efficient, and I will add this improvement.

ClientRPC interface is not symmetrical, there are getXAttr(), getXAttrs(), setXAttr(), so
there should be setXAttrs().
We have dicussed during design and are not intended to support setXAttrs currently, it's close
to POSIX setxattr and there is no use case for setXAttrs currently. We can extend this in
future. Please go to see HADOOP-10520.

why there is no getXAttr() in the ClientProtocol? we should allow to get only one xattr in
one time.
Agree with Uma.

Can you add Javadoc in DFSClient?
Agree with Uma. We could improve the javadoc for internal methods  in other JIRA.

> Protobuf for XAttr and client-side implementation 
> --------------------------------------------------
>                 Key: HDFS-6299
>                 URL: https://issues.apache.org/jira/browse/HDFS-6299
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Uma Maheswara Rao G
>            Assignee: Yi Liu
>             Fix For: HDFS XAttrs (HDFS-2006)
>         Attachments: HDFS-6299.patch
> This JIRA tracks Protobuf for XAttr and implementation for XAttr interfaces in DistributedFilesystem
and DFSClient. 
> With this JIRA we may just keep the dummy  implemenation for Xattr API of ClientProtocol
in NameNodeRpcServer

This message was sent by Atlassian JIRA

View raw message