hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6258) Support XAttrs from NameNode and implements XAttr APIs for DistributedFileSystem
Date Thu, 24 Apr 2014 21:07:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980289#comment-13980289
] 

Chris Nauroth commented on HDFS-6258:
-------------------------------------

I think this patch could effectively be split into at least 4 patches as follows:
# Protocol definitions, client-side calls, and {{NameNodeRpcServer}} stubbed right before
the typical delegation into {{FSNamesystem}}.  Once there is agreement on the protocol, a
lot of this code becomes boilerplate and quick to review.
# Implement the server-side storage/retrieval in memory: the inode classes, {{FSNamesystem}}
and friends.
# Persistence to fsimage and edit log.  As part of this, please make sure there are tests
that cover: 1) save xattrs, restart NN, assert xattrs reloaded from edit log, 2) save xattrs,
create new checkpoint, restart NN, assert xattrs reloaded from fsimage.
# Add in {{XAttrConfigFlag}} as the last patch, and consider refactoring to share code with
{{AclConfigFlag}}.  I'm pretty sure the two are nearly identical right now, except for being
driven by different configuration properties.

At some point in this plan, it will make sense to add the CLI tests.  It's probably feasible
to include that in #2, or if the CLI test suite is looking like a fairly large patch on its
own, then you could separate that out.  (Since you're on a feature branch, you have more flexibility
to submit tests later, as long as sufficient tests are in place by the time you propose merge.)

Thanks, Yi!

> Support XAttrs from NameNode and implements XAttr APIs for DistributedFileSystem
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-6258
>                 URL: https://issues.apache.org/jira/browse/HDFS-6258
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-6258.1.patch, HDFS-6258.2.patch, HDFS-6258.3.patch, HDFS-6258.patch
>
>
> This JIRA is to implement extended attributes in HDFS: support XAttrs from NameNode,
implements XAttr APIs for DistributedFileSystem and so on.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message