hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6226) Replace logging calls that use StringUtils.stringifyException to pass the exception instance to the log call.
Date Thu, 10 Apr 2014 08:06:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965110#comment-13965110
] 

Steve Loughran commented on HDFS-6226:
--------------------------------------

+1 for this; its a historical relic that actually loses data which different appenders (e.g
the json appender) to not see data.

This could also be a time to move to SLF4J for a logging api?

> Replace logging calls that use StringUtils.stringifyException to pass the exception instance
to the log call.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6226
>                 URL: https://issues.apache.org/jira/browse/HDFS-6226
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>
> There are multiple places in the code that call {{StringUtils#stringifyException}} to
capture the stack trace in a string and pass the result to a logging call.  The resulting
information is identical to passing the exception instance directly to the logger, i.e. {{LOG.error("fail",
e)}}, so we can simplify the code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message