hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6194) Create new tests for {{ByteRangeInputStream}}
Date Mon, 14 Apr 2014 02:13:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968017#comment-13968017
] 

Akira AJISAKA commented on HDFS-6194:
-------------------------------------

Thanks for the comment.
bq. The test code should not depend on the internal state of the {{ByteRangeInputStream}}.
Removed some initializations.
{code}
+    Whitebox.setInternalState(bris, "status",
+                              ByteRangeInputStream.StreamStatus.SEEK);
{code}
This setting is required. If {{status}} is not initialized, {{getInputStream()}} will fail
by NPE.

> Create new tests for {{ByteRangeInputStream}}
> ---------------------------------------------
>
>                 Key: HDFS-6194
>                 URL: https://issues.apache.org/jira/browse/HDFS-6194
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Akira AJISAKA
>         Attachments: HDFS-6194.2.patch, HDFS-6194.3.patch, HDFS-6194.4.patch, HDFS-6194.patch
>
>
> HDFS-5570 removes old tests for {{ByteRangeInputStream}}, because the tests only are
tightly coupled with hftp / hsftp. New tests need to be written because the same class is
also used by {{WebHdfsFileSystem}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message