hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6170) Support GETFILESTATUS operation in WebImageViewer
Date Wed, 09 Apr 2014 17:50:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964455#comment-13964455
] 

Haohui Mai commented on HDFS-6170:
----------------------------------

{code}
+  private void compareFile(FileStatus expected, FileStatus status) {
{code}

It should be a private static method.

{code}
+  public String getFileStatus(String path) throws IOException {
{code}

It might be better to mark all methods and the {{FSImageLoader}} class as package local instead
of public.

Other than that the patch looks good to me.

> Support GETFILESTATUS operation in WebImageViewer
> -------------------------------------------------
>
>                 Key: HDFS-6170
>                 URL: https://issues.apache.org/jira/browse/HDFS-6170
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: tools
>    Affects Versions: 2.5.0
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>              Labels: newbie
>         Attachments: HDFS-6170.patch
>
>
> WebImageViewer is created by HDFS-5978 but now supports only {{LISTSTATUS}} operation.
{{GETFILESTATUS}} operation is required for users to execute "hdfs dfs -ls webhdfs://foo"
on WebImageViewer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message