hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5216) NumDecomDeadDataNodes not returning correct number of dead decommissioned nodes
Date Thu, 03 Apr 2014 06:57:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958581#comment-13958581
] 

Konstantin Boudnik commented on HDFS-5216:
------------------------------------------

Arghh... my bad [~szetszwo], thanks for taking care of this!

> NumDecomDeadDataNodes not returning correct number of dead decommissioned nodes 
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-5216
>                 URL: https://issues.apache.org/jira/browse/HDFS-5216
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta
>            Reporter: Trevor Lorimer
>            Assignee: Trevor Lorimer
>         Attachments: HDFS-5216.diff, HDFS-5216.diff
>
>
> For HDFS-4860 I essentially copied the process in NamenodejspHelper.generateHealthReport(),
so it would be in sync with the original dfsHealth.jsp.
> However looking at this now there may be a bug? in getNumDecomDeadDataNodes(), where:
>     getBlockManager().getDatanodeManager().fetchDatanodes(dead, null, true);
>     
> Where the parameter true indicates that decommissioned nodes should be removed from the
list.
> If the flag is true fetchDatanodes calls removeDecomNodeFromList, which will remove a
node if an existing datanode does not appear in both include or exclude lists and it has been
decommissioned.
> If I am looking to return the Number of Dead Decommissioned Nodes, should I change the
remove decommissioned nodes flag to False? i.e.:
>     getBlockManager().getDatanodeManager().fetchDatanodes(null, dead, false);



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message