Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 8 Mar 2014 23:42:43 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12699288.1394148057270.30824.1394322162995@arcas>
In-Reply-To: <JIRA.12699288.1394148057270@arcas>
References: <JIRA.12699288.1394148057270@arcas>
Subject: [jira] [Commented] (HDFS-6071) BlockReaderLocal doesn't return -1
 on EOF when doing a zero-length read on a short file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925050#comment-13925050 ] 

Hadoop QA commented on HDFS-6071:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12633562/HDFS-6071.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6358//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6358//console

This message is automatically generated.

> BlockReaderLocal doesn't return -1 on EOF when doing a zero-length read on a short file
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-6071
>                 URL: https://issues.apache.org/jira/browse/HDFS-6071
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-6071.001.patch, HDFS-6071.002.patch
>
>
> BlockReaderLocal doesn't return -1 on EOF when doing a zero-length read on a short file.  Specifically, if the file is shorter than the readahead buffer, or if the position is nearer to the end than the length of the readahead buffer, this may happen.  This is mainly a concern because libhdfs relies on this to determine whether it should use direct reads.


--
This message was sent by Atlassian JIRA
(v6.2#6252)