Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 17 Mar 2014 14:45:46 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12699272.1394142675538.89724.1395067546069@arcas>
In-Reply-To: <JIRA.12699272.1394142675538@arcas>
References: <JIRA.12699272.1394142675538@arcas>
Subject: [jira] [Commented] (HDFS-6068) Disallow snapshot names that are
 also invalid directory names
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-6068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937870#comment-13937870 ] 

Hadoop QA commented on HDFS-6068:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12635063/HDFS-6068-0003.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6413//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6413//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6413//console

This message is automatically generated.

> Disallow snapshot names that are also invalid directory names
> -------------------------------------------------------------
>
>                 Key: HDFS-6068
>                 URL: https://issues.apache.org/jira/browse/HDFS-6068
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.4.0
>            Reporter: Andrew Wang
>            Assignee: sathish
>         Attachments: HDFS-6068-0001.patch, HDFS-6068-0002.patch, HDFS-6068-0003.patch
>
>
> There are a number of restrictions on valid names in HDFS. For example, you can't name a directory "." or "..", or something containing a ":".
> However, I can happily create a snapshot named "a:b:c", resulting in this:
> {code}
> -> % hdfs dfs -createSnapshot /home/andrew a:b:c
> Created snapshot /home/andrew/.snapshot/a:b:c
> -> % hadoop fs -ls /home/andrew/.snapshot
> -ls: java.net.URISyntaxException: Relative path in absolute URI: a:b:c
> Usage: hadoop fs [generic options] -ls [-d] [-h] [-R] [<path> ...]
> {code}


--
This message was sent by Atlassian JIRA
(v6.2#6252)