Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5803E10C78 for ; Thu, 6 Mar 2014 22:45:53 +0000 (UTC) Received: (qmail 23321 invoked by uid 500); 6 Mar 2014 22:45:44 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 23255 invoked by uid 500); 6 Mar 2014 22:45:44 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 23245 invoked by uid 99); 6 Mar 2014 22:45:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2014 22:45:44 +0000 Date: Thu, 6 Mar 2014 22:45:44 +0000 (UTC) From: "Tsz Wo Nicholas Sze (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6038) JournalNode hardcodes NameNodeLayoutVersion in the edit log file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923198#comment-13923198 ] Tsz Wo Nicholas Sze commented on HDFS-6038: ------------------------------------------- - DataOutputBuffer.writeInt can be simplified as below. {code} //DataOutputBuffer.java public void writeInt(int v, int offset) throws IOException { int oldCount = buffer.setOffset(offset); writeInt(v); buffer.setOffset(oldCount); } {code} - BookKeeperEditLogInputStream.scanNextOp() can be removed. - In EditLogFileInputStream.scanEditLog, the txid variable can be declared inside the while-loop. - FSEditLogOp.Reader.scanOp() needs to check OP_INVALID like decodeOp(). > JournalNode hardcodes NameNodeLayoutVersion in the edit log file > ---------------------------------------------------------------- > > Key: HDFS-6038 > URL: https://issues.apache.org/jira/browse/HDFS-6038 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, ha, hdfs-client, namenode > Reporter: Haohui Mai > Assignee: Jing Zhao > Attachments: HDFS-6038.000.patch, HDFS-6038.001.patch, HDFS-6038.002.patch, HDFS-6038.003.patch, HDFS-6038.004.patch, editsStored > > > In HA setup, the JNs receive edit logs (blob) from the NN and write into edit log files. In order to write well-formed edit log files, the JNs prepend a header for each edit log file. > The problem is that the JN hard-codes the version (i.e., {{NameNodeLayoutVersion}} in the edit log, therefore it generates incorrect edit logs when the newer release bumps the {{NameNodeLayoutVersion}} during rolling upgrade. -- This message was sent by Atlassian JIRA (v6.2#6252)