hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6120) Cleanup safe mode error messages
Date Thu, 20 Mar 2014 17:56:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942052#comment-13942052
] 

Jing Zhao commented on HDFS-6120:
---------------------------------

Thanks for the cleanup, Arpit! The patch looks good to me. Some minors:
# I guess here we should use "if (needEnter())" ?
{code}
+      if (!needEnter()) {
+        reportStatus("STATE* Safe mode ON, thresholds not met.", false);
+      }
{code}
# For getTurnOffTip(), do you think we need an extra msg to report the value of "reached"
and the corresponding status (safe mode off, or on, or in extension)? After the NN comes into
the safemode extension, the safe block count may still fall below the threshold.

> Cleanup safe mode error messages
> --------------------------------
>
>                 Key: HDFS-6120
>                 URL: https://issues.apache.org/jira/browse/HDFS-6120
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-6120.01.patch
>
>
> In HA mode the SBN can enter safe-mode extension and stay there even after the extension
period has elapsed but continue to return the safemode message stating that "The threshold
has been reached" and "safe mode will be turned off soon".



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message