hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6102) Cannot load an fsimage with a very large directory
Date Thu, 13 Mar 2014 23:03:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934262#comment-13934262

Haohui Mai commented on HDFS-6102:

It looks mostly good to me. The only comment I have is that the code should no longer support
unlimited number of children in a directory, which is in {{FSDirectory#verifyMaxDirItems()}}.

    if (maxDirItems == 0) {

Otherwise users might run into a problem that the saved fsimage cannot be consumed. Do you
think it is a good idea to enforce a maximum limit, say, 6.7m based on your calculation?

> Cannot load an fsimage with a very large directory
> --------------------------------------------------
>                 Key: HDFS-6102
>                 URL: https://issues.apache.org/jira/browse/HDFS-6102
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.4.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>            Priority: Blocker
>         Attachments: hdfs-6102-1.patch
> Found by [~schu] during testing. We were creating a bunch of directories in a single
directory to blow up the fsimage size, and it ends up we hit this error when trying to load
a very large fsimage:
> {noformat}
> 2014-03-13 13:57:03,901 INFO org.apache.hadoop.hdfs.server.namenode.FSImageFormatPBINode:
Loading 24523605 INodes.
> 2014-03-13 13:57:59,038 ERROR org.apache.hadoop.hdfs.server.namenode.FSImage: Failed
to load image from FSImageFile(file=/dfs/nn/current/fsimage_0000000000024532742, cpktTxId=0000000000024532742)
> com.google.protobuf.InvalidProtocolBufferException: Protocol message was too large. 
May be malicious.  Use CodedInputStream.setSizeLimit() to increase the size limit.
>         at com.google.protobuf.InvalidProtocolBufferException.sizeLimitExceeded(InvalidProtocolBufferException.java:110)
>         at com.google.protobuf.CodedInputStream.refillBuffer(CodedInputStream.java:755)
>         at com.google.protobuf.CodedInputStream.readRawByte(CodedInputStream.java:769)
>         at com.google.protobuf.CodedInputStream.readRawVarint64(CodedInputStream.java:462)
>         at com.google.protobuf.CodedInputStream.readUInt64(CodedInputStream.java:188)
>         at org.apache.hadoop.hdfs.server.namenode.FsImageProto$INodeDirectorySection$DirEntry.<init>(FsImageProto.java:9839)
>         at org.apache.hadoop.hdfs.server.namenode.FsImageProto$INodeDirectorySection$DirEntry.<init>(FsImageProto.java:9770)
>         at org.apache.hadoop.hdfs.server.namenode.FsImageProto$INodeDirectorySection$DirEntry$1.parsePartialFrom(FsImageProto.java:9901)
>         at org.apache.hadoop.hdfs.server.namenode.FsImageProto$INodeDirectorySection$DirEntry$1.parsePartialFrom(FsImageProto.java:9896)
>         at 52)
> ...
> {noformat}
> Some further research reveals there's a 64MB max size per PB message, which seems to
be what we're hitting here.

This message was sent by Atlassian JIRA

View raw message