hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6057) DomainSocketWatcher.watcherThread should be marked as daemon thread
Date Thu, 06 Mar 2014 03:45:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921966#comment-13921966
] 

Hadoop QA commented on HDFS-6057:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12632984/HDFS-6057.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.cli.TestHDFSCLI
                  org.apache.hadoop.hdfs.TestPread

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6317//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6317//console

This message is automatically generated.

> DomainSocketWatcher.watcherThread should be marked as daemon thread
> -------------------------------------------------------------------
>
>                 Key: HDFS-6057
>                 URL: https://issues.apache.org/jira/browse/HDFS-6057
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.4.0
>            Reporter: Eric Sirianni
>            Assignee: Colin Patrick McCabe
>            Priority: Blocker
>         Attachments: HDFS-6057.002.patch, HDFS-6057.003.patch, hdfs-6057-v1.txt
>
>
> Running the tip of {{branch-2.4}}, I'm observing some zombie processes in my environment.
 jstack shows the following thread preventing the JVM from shutting down:
> {noformat}
> "Thread-3" prio=10 tid=0x00007f0a908a5800 nid=0x3ee9 runnable [0x00007f0a89471000]
>    java.lang.Thread.State: RUNNABLE
> 	at org.apache.hadoop.net.unix.DomainSocketWatcher.doPoll0(Native Method)
> 	at org.apache.hadoop.net.unix.DomainSocketWatcher.access$800(DomainSocketWatcher.java:52)
> 	at org.apache.hadoop.net.unix.DomainSocketWatcher$1.run(DomainSocketWatcher.java:455)
> 	at java.lang.Thread.run(Thread.java:679)
> {noformat}
> Marking the {{DomainSocketWatcher.watcherThread}} as a daemon thread would prevent this
situation.  Is there any reason it isn't classified as such?
> Also, tracing through the code, I don't see any code path where {{DomainSocketWatcher.close()}}
is invoked (though this would seem to be a larger issue -- maybe I'm missing something...).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message