hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6050) NFS OpenFileCtx does not handle exceptions correctly
Date Wed, 05 Mar 2014 01:17:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920350#comment-13920350

Brandon Li commented on HDFS-6050:

{quote}An operator could entirely reasonably just run their NFS3 gateway against a different
config directory than their NFS4 gateway, even if they were on the same box.{quote}
This should be fine. I was actually concerned about that users may have hard time to set the
right property for the right protocol version if all of them are named as dfs.nfs.xxx.  

{quote}"dfs.nfs3.export.point" was chosen to be specific to just NFS3?{quote}
This is a mistake.

Nevertheless, the current variable names are confusing and the property in hadoop-common should
not be named as dfs.xxx. 
We can name nfs configuration in hadoop-hdfs-nfs as dfs.nfs.xxx and hadoop.nfs.xxx in hadoop-common.
Even v4 is implemented later on, we are not going to add dfs.nfs4.xxx but only add the version
information to the properties description in code (e.g., DFSConfigKeys.java) and configuration
file (e.g., hdfs-default.xml). Using documentation instead of name hierarchy to help users
do the right configuration.

This will be an incompatible change. If this sounds good to you, please file a JIRA as you
planned, and let's keep this JIRA for the compatible code changes.

> NFS OpenFileCtx does not handle exceptions correctly
> ----------------------------------------------------
>                 Key: HDFS-6050
>                 URL: https://issues.apache.org/jira/browse/HDFS-6050
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>            Reporter: Brock Noland
>            Assignee: Brandon Li
> I noticed this file does not log exceptions appropriately in multiple locations.
> Not logging the stack of Throwable:
> https://github.com/apache/hadoop-common/blob/f567f09091368fe800f3f70605da38a69c953fe3/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtx.java#L364
> Printing exceptions to stderr:
> https://github.com/apache/hadoop-common/blob/f567f09091368fe800f3f70605da38a69c953fe3/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtx.java#L1160
> https://github.com/apache/hadoop-common/blob/f567f09091368fe800f3f70605da38a69c953fe3/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtx.java#L1149
> Not logging the stack trace:
> https://github.com/apache/hadoop-common/blob/f567f09091368fe800f3f70605da38a69c953fe3/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtx.java#L1062
> https://github.com/apache/hadoop-common/blob/f567f09091368fe800f3f70605da38a69c953fe3/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtx.java#L966
> https://github.com/apache/hadoop-common/blob/f567f09091368fe800f3f70605da38a69c953fe3/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtx.java#L961
> https://github.com/apache/hadoop-common/blob/f567f09091368fe800f3f70605da38a69c953fe3/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtx.java#L680

This message was sent by Atlassian JIRA

View raw message