hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5591) Checkpointing should use monotonic time when calculating period
Date Thu, 27 Mar 2014 18:56:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949792#comment-13949792
] 

Andrew Wang commented on HDFS-5591:
-----------------------------------

Looks like this test needs to be updated. It'd also be good to add an error message to the
assert, so we get something more descriptive next time.

{code}
+      + "\nLast Checkpoint      : " + (lastCheckpointTime == 0? "--": new Date(lastCheckpointTime))
+ " seconds ago"
{code}

Putting this into a Date also isn't quite right, we just want to print a duration in seconds
(so time/1000).

+1 once these are addressed though.

> Checkpointing should use monotonic time when calculating period
> ---------------------------------------------------------------
>
>                 Key: HDFS-5591
>                 URL: https://issues.apache.org/jira/browse/HDFS-5591
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.2.0
>            Reporter: Andrew Wang
>            Assignee: Charles Lamb
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-5591.001.patch, HDFS-5591.002.patch, HDFS-5591.003.patch
>
>
> Both StandbyCheckpointer and SecondaryNameNode use {{Time.now}} rather than {{Time.monotonicNow}}
to calculate how long it's been since the last checkpoint. This can lead to issues when the
system time is changed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message