hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5570) Deprecate hftp / hsftp and replace them with webhdfs / swebhdfs
Date Thu, 27 Mar 2014 22:57:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950071#comment-13950071
] 

Jing Zhao commented on HDFS-5570:
---------------------------------

Some quick comments:
# We should use "commandCount > 1" as the condition in the following code.
{code}
-    if (cancel && renew || cancel && print || renew && print || cancel
&& renew
-        && print) {
+
+    int commandCount = (cancel ? 1 : 0) + (renew ? 1 : 0) + (print ? 1 : 0);
+    if (commandCount != 1) {
{code}
# We need to have new unit tests for DelegationTokenFetcher, which can cover all the cli options.
This may be addressed in a separate jira.

> Deprecate hftp / hsftp and replace them with webhdfs / swebhdfs
> ---------------------------------------------------------------
>
>                 Key: HDFS-5570
>                 URL: https://issues.apache.org/jira/browse/HDFS-5570
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5570.000.patch, HDFS-5570.001.patch, HDFS-5570.002.patch, HDFS-5570.003.patch,
HDFS-5570.004.patch, HDFS-5570.005.patch, HDFS-5570.006.patch, HDFS-5570.007.patch
>
>
> Currently hftp / hsftp only provide a strict subset of functionality that webhdfs / swebhdfs
offer. Notably, hftp / hsftp do not support writes and HA namenodes. Maintaining two piece
of code with similar functionality introduce unnecessary work.
> Webhdfs has been around since Hadoop 1.0 therefore moving forward with webhdfs does not
seem to cause any significant migration issues.
> This jira proposes to deprecate hftp / hsftp in branch-2 and remove them in trunk.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message