hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5196) Provide more snapshot information in WebUI
Date Wed, 19 Mar 2014 23:49:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941189#comment-13941189
] 

Haohui Mai commented on HDFS-5196:
----------------------------------

{code}
+    private final String modificationTime;
+    private final String permission;
{code}

They should be long and short respectively.

{code}
+  public SnapshottableDirectoryStatus.Bean[] getSnapshottableDirs() { ...
+  public SnapshotInfo.Bean[] getSnapshottedDirs() { ...
{code}

I think it is okay for them to return {{null}} here if no snapshottable are found.

Looking at the code, it might make more sense to create a MXBean of the {{SnapshotManager}}
to record all the information. The motivation is that both {{FSNamesystemState}} and {{NameNodeInfo}}
are frequently queried but the snapshot information is not. That way also allows the UI makes
only one HTTP call instead of two. What do you think?

> Provide more snapshot information in WebUI
> ------------------------------------------
>
>                 Key: HDFS-5196
>                 URL: https://issues.apache.org/jira/browse/HDFS-5196
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: snapshots
>    Affects Versions: 3.0.0
>            Reporter: Haohui Mai
>            Assignee: Shinichi Yamashita
>            Priority: Minor
>         Attachments: HDFS-5196-2.patch, HDFS-5196-3.patch, HDFS-5196-4.patch, HDFS-5196-5.patch,
HDFS-5196-6.patch, HDFS-5196.patch, HDFS-5196.patch, HDFS-5196.patch, snapshot-new-webui.png,
snapshottable-directoryList.png, snapshotteddir.png
>
>
> The WebUI should provide more detailed information about snapshots, such as all snapshottable
directories and corresponding number of snapshots (suggested in HDFS-4096).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message