Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1BEBB109CA for ; Wed, 12 Feb 2014 23:08:27 +0000 (UTC) Received: (qmail 75294 invoked by uid 500); 12 Feb 2014 23:08:21 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 75250 invoked by uid 500); 12 Feb 2014 23:08:20 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 75229 invoked by uid 99); 12 Feb 2014 23:08:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Feb 2014 23:08:19 +0000 Date: Wed, 12 Feb 2014 23:08:19 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-5940) Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Patrick McCabe updated HDFS-5940: --------------------------------------- Status: Patch Available (was: Open) > Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher > ------------------------------------------------------------------------------ > > Key: HDFS-5940 > URL: https://issues.apache.org/jira/browse/HDFS-5940 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Affects Versions: 2.4.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-5940.001.patch, HDFS-5940.002.patch > > > ShortCircuitReplica#Key and FsDatasetCache#Key are pretty much identical code and should be factored out to an external class. (There will soon be a need for a third user of such an identifier.) > Another minor cleanup is that DomainSocketWatcher should not implement Thread. It contains a thread currently, but I forgot to remove the "extends". -- This message was sent by Atlassian JIRA (v6.1.5#6160)