hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6013) add rollingUpgrade information to latest UI
Date Thu, 27 Feb 2014 07:28:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914160#comment-13914160
] 

Haohui Mai commented on HDFS-6013:
----------------------------------

{code}
+   * Gets the RollingUpgrade information
+   * 
+   * @return Rolling upgrade information
+   */
+  public String getRollingUpgradeStatus();
{code}

I think it might be better to return a MXBean to capture all information. For example:

{code}
RollingUpgradeInfo.java
 public class RollingUpgradeInfo extends RollingUpgradeStatus {
+  public static class Bean {
+    private final String blockPoolId;
+    private final long startTime;
+    private final long finalizeTime;
+    private final boolean createdRollbackImages;
+    public Bean(RollingUpgradeInfo f) {
+      this.blockPoolId = f.getBlockPoolId();
+      this.startTime = f.startTime;
+      this.finalizeTime = f.finalizeTime;
+      this.createdRollbackImages = f.createdRollbackImages();
+    }
+    public String getBlockPoolId() {
+      return blockPoolId;
+    }
+    public long getStartTime() {
+      return startTime;
+    }
+    public long getFinalizeTime() {
+      return finalizeTime;
+    }
+    public boolean isCreatedRollbackImages() {
+      return createdRollbackImages;
+    }
+  }

...
NamenodeMXBean.java:
+  RollingUpgradeInfo.Bean getRollingUpgradeInfoStatus();
{code}

([~szetszwo], do you think it is possible to fold it into {{RollingUpgradeInfo}}?)

That way the resulted jmx looks like the following:

{code}
"RollingUpgradeInfoStatus" : {
      "blockPoolId" : "bpid",
      "createdRollbackImages" : true,
      "finalizeTime" : 5,
      "startTime" : 3
    }
{code}

As a first step I think it is sufficient to only tell whether the cluster is in rolling upgrade
mode or not.

{code}
+{#nn}
+{#RollingUpgradeStatus}
+  <p>
+    <b>RollingUpgrade in-progress : </b> <br>
+    {.}
+  </p>
+{/RollingUpgradeStatus}
+{/nn}
{code}

{{<br>}} needs to be {{<br/>}}. It might also need to be placed along with the
code checking {{DistinctVersionCount}}.

Can you also provide screenshots of UI that reflects the changes?

> add rollingUpgrade information to  latest UI
> --------------------------------------------
>
>                 Key: HDFS-6013
>                 URL: https://issues.apache.org/jira/browse/HDFS-6013
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-6013.patch, HDFS-6013.patch
>
>
> Rolling Upgrade information should be shown in the latest NameNode UI.
> For this RollingUpgrade information should be exposed as jmx bean.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message