hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5982) Need to update snapshot manager when applying editlog for deleting a snapshottable directory
Date Fri, 21 Feb 2014 11:06:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908172#comment-13908172
] 

Hudson commented on HDFS-5982:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk #488 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/488/])
HDFS-5982. Need to update snapshot manager when applying editlog for deleting a snapshottable
directory. Contributed by Jing Zhao. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570395)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDeletion.java


> Need to update snapshot manager when applying editlog for deleting a snapshottable directory
> --------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5982
>                 URL: https://issues.apache.org/jira/browse/HDFS-5982
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Jing Zhao
>            Priority: Critical
>             Fix For: 2.4.0
>
>         Attachments: HDFS-5982.000.patch, HDFS-5982.001.patch, HDFS-5982.001.patch
>
>
> Currently after deleting a snapshottable directory which does not have snapshots any
more, we also remove the directory from the snapshottable directory list in SnapshotManager.
This works fine when handling a delete request from user. However, when we apply the OP_DELETE
editlog, FSDirectory#unprotectedDelete(String, long) is called, which does not contain the
"updating snapshot manager" process. This may leave an non-existent inode id in the snapshottable
directory list, and can even lead to FSImage corruption.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message