hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5982) Need to update snapshot manager when applying editlog for deleting a snapshottable directory
Date Thu, 20 Feb 2014 09:42:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906806#comment-13906806
] 

Hadoop QA commented on HDFS-5982:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12630004/HDFS-5982.000.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.TestEditLogRace

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6191//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6191//console

This message is automatically generated.

> Need to update snapshot manager when applying editlog for deleting a snapshottable directory
> --------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5982
>                 URL: https://issues.apache.org/jira/browse/HDFS-5982
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Jing Zhao
>            Priority: Critical
>         Attachments: HDFS-5982.000.patch
>
>
> Currently after deleting a snapshottable directory which does not have snapshots any
more, we also remove the directory from the snapshottable directory list in SnapshotManager.
This works fine when handling a delete request from user. However, when we apply the OP_DELETE
editlog, FSDirectory#unprotectedDelete(String, long) is called, which does not contain the
"updating snapshot manager" process. This may leave an non-existent inode id in the snapshottable
directory list, and can even lead to FSImage corruption.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message