hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5940) Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher
Date Wed, 12 Feb 2014 22:14:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899663#comment-13899663
] 

Andrew Wang commented on HDFS-5940:
-----------------------------------

Few comments:

* Slap a @VisibleForTesting annotation for watcherThread
* BlockIdentifier javadoc refers to "BlockDescriptors"
* We might want to call it "ExtendedBlockIdentifier" since an ExtendedBlock is what also has
the bpid, but that is a mouthful. ExtendedBlockKey?

+1 pending above and Jenkins.

> Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-5940
>                 URL: https://issues.apache.org/jira/browse/HDFS-5940
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5940.001.patch
>
>
> ShortCircuitReplica#Key and FsDatasetCache#Key are pretty much identical code and should
be factored out to an external class.  (There will soon be a need for a third user of such
an identifier.)
> Another minor cleanup is that DomainSocketWatcher should not implement Thread.  It contains
a thread currently, but I forgot to remove the "extends".



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message