hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5939) WebHdfs returns misleading error code and logs nothing if trying to create a file with no DNs in cluster
Date Fri, 21 Feb 2014 23:07:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908966#comment-13908966
] 

Aaron T. Myers commented on HDFS-5939:
--------------------------------------

bq. I'm not a big fan of verbose code. If you want it for debugging, you can always make the
modification locally, I don't see the value of putting it into the repo.

Let's please focus on reviewing issues with the actual functionality, or with the correctness
of the test. I personally think that having this in the test has the potential to make debugging
a test failure in an automated Jenkins run a bit easier. Reasonable people will disagree here,
and we shouldn't try to impose personal coding preferences on others during review. The correctness
of the unit tests is vastly more important than the style, or the verbosity of the debug output.

bq. This unit test reproduces the problem. <snip>

Yes, I was about to post this myself. The issue that Yongjun's original test was working around
is the fact that the MiniDFSCluster mutates the configuration to set the replication the number
of datanodes in the cluster. Manually setting the conf's replication setting to something
> 0 seems like the better solution.

> WebHdfs returns misleading error code and logs nothing if trying to create a file with
no DNs in cluster
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5939
>                 URL: https://issues.apache.org/jira/browse/HDFS-5939
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.3.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-5939.001.patch, HDFS-5939.002.patch, HDFS-5939.003.patch, HDFS-5939.004.patch
>
>
> When trying to access hdfs via webhdfs, and when datanode is dead, user will see an exception
below without any clue that it's caused by dead datanode:
> $ curl -i -X PUT ".../webhdfs/v1/t1?op=CREATE&user.name=<userName>&overwrite=false"
> ...
> {"RemoteException":{"exception":"IllegalArgumentException","javaClassName":"java.lang.IllegalArgumentException","message":"n
must be positive"}}
> Need to fix the report to give user hint about dead datanode.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message