hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5937) Fix TestOfflineEditsViewer on HDFS-4685 branch.
Date Thu, 13 Feb 2014 06:38:22 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HDFS-5937:
--------------------------------

    Attachment: editsStored
                HDFS-5937.2.patch

Here is v2 of this patch.  Now it's ready for review.

# {{FSEditLogOp}}: The test exposed a small bug by round-tripping from binary edits to XML
and then back to binary again.  Serialization of {{OP_SET_ACL}} to XML for an empty list of
entries does not emit any {{ENTRY}} elements.  Then, deserializing from XML creates an instance
of {{SetAclOp}} with a null ACL entry list.  Then, serializing that to binary fails with a
{{NullPointerException}}, because the expectation is that an {{OP_SET_ACL}} always has a non-null
list of entries.  I fixed it by guaranteeing that we get a non-null list when reading from
XML.  Note that it's still the right behavior for {{readAclEntriesFromXml}} to return null
to support {{OP_ADD}} and {{OP_MKDIR}}, where the entries list is truly optional.
# {{OfflineEditsViewerHelper}}: Enable ACLs in configuration.
# editsStored/editsStored.xml: Update the checked in edits files used by the tests.

The binary editsStored file is not included in the patch.  I'm attaching that separately.

> Fix TestOfflineEditsViewer on HDFS-4685 branch.
> -----------------------------------------------
>
>                 Key: HDFS-5937
>                 URL: https://issues.apache.org/jira/browse/HDFS-5937
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: HDFS-5937.1.patch, HDFS-5937.2.patch, editsStored
>
>
> {{TestOfflineEditsViewer}} currently fails on the HDFS-4685 branch.  The scope of this
issue is to get the test passing again.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message