hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5932) Ls should display the ACL bit
Date Thu, 13 Feb 2014 01:48:19 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899911#comment-13899911
] 

Haohui Mai commented on HDFS-5932:
----------------------------------

{code}
 +                                     RpcNoSuchMethodException.class,
                                      UnresolvedPathException.class);
{code}

It's a little bit weird to unwrap {{RpcNoSuchMethodException}} in {{DFSClient}}. Comparing
the v2 and v3 patch, it might be better to stick with the v2 version.

The unit test can be greatly simplified using mockito, but it can be addressed in a separate
jira.

Other than that the patch looks pretty good.

> Ls should display the ACL bit
> -----------------------------
>
>                 Key: HDFS-5932
>                 URL: https://issues.apache.org/jira/browse/HDFS-5932
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode, security
>            Reporter: Haohui Mai
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5932.1.patch, HDFS-5932.2.patch, HDFS-5932.3.patch
>
>
> Based on the discussion of HDFS-5923, the ACL bit is no longer passed to the client directly.
Ls should call {{getAclStatus()}} instead since it needs to display the ACL bit as a part
of the permission.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message