hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5913) Nfs3Utils#getWccAttr() should check attr parameter against null
Date Sun, 09 Feb 2014 23:10:19 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896097#comment-13896097
] 

Brandon Li commented on HDFS-5913:
----------------------------------

[~yuzhihong@gmail.com], Nfs3Utils#getWccAttr()  in the above case does dereference for preOpAttr,
not postOpAttr. 

{quote}If there is exception, postOpAttr would be null.{quote}
I guess you meant preOpAttr. right?



> Nfs3Utils#getWccAttr() should check attr parameter against null
> ---------------------------------------------------------------
>
>                 Key: HDFS-5913
>                 URL: https://issues.apache.org/jira/browse/HDFS-5913
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>            Reporter: Ted Yu
>            Priority: Minor
>
> In RpcProgramNfs3#commit() :
> {code}
>       Nfs3FileAttributes postOpAttr = null;
>       try {
>         postOpAttr = writeManager.getFileAttr(dfsClient, handle, iug);
>       } catch (IOException e1) {
>         LOG.info("Can't get postOpAttr for fileId: " + handle.getFileId());
>       }
>       WccData fileWcc = new WccData(Nfs3Utils.getWccAttr(preOpAttr), postOpAttr);
> {code}
> If there is exception, postOpAttr would be null.
> However, Nfs3Utils#getWccAttr() dereferences attr parameter directly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message