hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5885) Add annotation for repeated fields in the protobuf definition
Date Thu, 06 Feb 2014 00:16:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892797#comment-13892797
] 

Haohui Mai commented on HDFS-5885:
----------------------------------

Based on the statistics on a FSImage in production, I estimate that this optimization can
save around 10% of the space.

My concern is that the information of blocks might be changed in the near future (e.g, by
HDFS-2832). The shredded version makes it less intuitive.

Therefore I think it might be better to revisit this after the merge. What do you think?

> Add annotation for repeated fields in the protobuf definition
> -------------------------------------------------------------
>
>                 Key: HDFS-5885
>                 URL: https://issues.apache.org/jira/browse/HDFS-5885
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-5698 (FSImage in protobuf)
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5885.000.patch, HDFS-5885.001.patch
>
>
> As suggested by the documentation of Protocol Buffers, the protobuf specification of
the fsimage should specify [packed=true] for all repeated fields.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message