hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5882) TestAuditLogs is flaky
Date Wed, 05 Feb 2014 18:26:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892387#comment-13892387
] 

Colin Patrick McCabe commented on HDFS-5882:
--------------------------------------------

Putting sleeps into tests like this is brittle.  Let's not go down that road.

If flushing is impossible, why not keep retrying reading the log for a fixed amount of time?
 GenericTestUtils#waitFor can help with this.

> TestAuditLogs is flaky
> ----------------------
>
>                 Key: HDFS-5882
>                 URL: https://issues.apache.org/jira/browse/HDFS-5882
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: hdfs-5882.patch
>
>
> TestAuditLogs fails sometimes:
> {noformat}
> Running org.apache.hadoop.hdfs.server.namenode.TestAuditLogs
> Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 37.913 sec <<<
FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestAuditLogs
> testAuditAllowedStat[1](org.apache.hadoop.hdfs.server.namenode.TestAuditLogs)  Time elapsed:
2.085 sec  <<< FAILURE!
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:92)
> 	at org.junit.Assert.assertTrue(Assert.java:43)
> 	at org.junit.Assert.assertNotNull(Assert.java:526)
> 	at org.junit.Assert.assertNotNull(Assert.java:537)
> 	at org.apache.hadoop.hdfs.server.namenode.TestAuditLogs.verifyAuditLogsRepeat(TestAuditLogs.java:312)
> 	at org.apache.hadoop.hdfs.server.namenode.TestAuditLogs.verifyAuditLogs(TestAuditLogs.java:295)
> 	at org.apache.hadoop.hdfs.server.namenode.TestAuditLogs.testAuditAllowedStat(TestAuditLogs.java:163)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message