hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5616) NameNode: implement default ACL handling.
Date Fri, 07 Feb 2014 19:11:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894870#comment-13894870
] 

Haohui Mai commented on HDFS-5616:
----------------------------------

{code}                                                                                   
                                                                                         
                           
+      } else if (type == AclEntryType.MASK) {                                           
                                                                                         
                           
+        permission = entry.getPermission().and(childPerm.getGroupAction());             
                                                                                         
                           
{code}                                                                                   
                                                                                         
                           
                                                                                         
                                                                                         
                           
It looks inconsistent with other branches. Is it intentional?                            
                                                                                         
                           
                                                                                         
                                                                                         
                           
{code}                                                                                   
                                                                                         
                           
+    return new AclFeature(Collections.unmodifiableList(featureEntries));                
                                                                                         
                           
{code}                                                                                   
                                                                                         
                           
                                                                                         
                                                                                         
                           
I think this is an issue might worth revisiting. Currently we place a {{List<AclEntry>}}
in {{AclFeature}}, which does not capture the fact that the list should be immutable. A better
approach is to change \
{{List<AclEntry>}} to {{ImmuableList<AclEntry>}} in the {{AclFeature}} class and
related functions to capture this fact. However, I think you can address it in a separate
jira.



> NameNode: implement default ACL handling.
> -----------------------------------------
>
>                 Key: HDFS-5616
>                 URL: https://issues.apache.org/jira/browse/HDFS-5616
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5616.1.patch, HDFS-5616.2.patch
>
>
> Implement and test handling of default ACLs within NameNode.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message