Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C993107AF for ; Fri, 31 Jan 2014 14:24:19 +0000 (UTC) Received: (qmail 50051 invoked by uid 500); 31 Jan 2014 14:24:17 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 49642 invoked by uid 500); 31 Jan 2014 14:24:16 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 49473 invoked by uid 99); 31 Jan 2014 14:24:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jan 2014 14:24:12 +0000 Date: Fri, 31 Jan 2014 14:24:12 +0000 (UTC) From: "Buddy (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-5828) BlockPlacementPolicyWithNodeGroup can place multiple replicas on the same node group when dfs.namenode.avoid.write.stale.datanode is true MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buddy updated HDFS-5828: ------------------------ Attachment: HDFS-5828a.patch Good point. I made the change and uploaded a new patch. Thanks Junping. > BlockPlacementPolicyWithNodeGroup can place multiple replicas on the same node group when dfs.namenode.avoid.write.stale.datanode is true > ----------------------------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-5828 > URL: https://issues.apache.org/jira/browse/HDFS-5828 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.3.0 > Reporter: Buddy > Attachments: HDFS-5828.patch, HDFS-5828a.patch > > > When placing replicas using the replica placement policy BlockPlacementPolicyWithNodeGroup, the number of targets returned should be less than or equal to the number of node groups and no node group should get two replicas of the same block. The Junit test TestReplicationPolicyWithNodeGroup.testChooseMoreTargetsThanNodeGroups verifies this. > However, if the conf property "dfs.namenode.avoid.write.stale.datanode" is set to true, then block placement policy will return more targets than node groups when the number of replicas requested exceeds the number of node groups. > This can be seen by putting: > CONF.setBoolean(DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_WRITE_KEY, true); > in the setup method for TestReplicationPolicyWithNodeGroup. This will cause testChooseMoreTargetsThanNodeGroups to fail. -- This message was sent by Atlassian JIRA (v6.1.5#6160)