Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 436CF10944 for ; Sat, 11 Jan 2014 00:16:57 +0000 (UTC) Received: (qmail 61405 invoked by uid 500); 11 Jan 2014 00:16:57 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 61366 invoked by uid 500); 11 Jan 2014 00:16:56 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 61357 invoked by uid 99); 11 Jan 2014 00:16:56 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2014 00:16:56 +0000 Date: Sat, 11 Jan 2014 00:16:56 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-5747) BlocksMap.getStoredBlock(..) and BlockInfoUnderConstruction.addReplicaIfNotPresent(..) may throw NullPointerException MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868514#comment-13868514 ] Hudson commented on HDFS-5747: ------------------------------ SUCCESS: Integrated in Hadoop-trunk-Commit #4987 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4987/]) HDFS-5747. Fix NPEs in BlockManager. (Arpit Agarwal) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1557289) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > BlocksMap.getStoredBlock(..) and BlockInfoUnderConstruction.addReplicaIfNotPresent(..) may throw NullPointerException > --------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-5747 > URL: https://issues.apache.org/jira/browse/HDFS-5747 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 3.0.0, 2.4.0 > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Arpit Agarwal > Priority: Minor > Attachments: HDFS-5747.01.patch > > > Found these NPEs in [build #5849|https://builds.apache.org/job/PreCommit-HDFS-Build/5849//testReport/org.apache.hadoop.hdfs/TestPersistBlocks/TestRestartDfsWithFlush/]. > - BlocksMap is accessed after close: > {code} > 2014-01-09 04:28:32,350 WARN ipc.Server (Server.java:run(2060)) - IPC Server handler 2 on 58333, call org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReceivedAndDeleted from 127.0.0.1:55572 Call#32 Retry#0: error: java.lang.NullPointerException > java.lang.NullPointerException > at org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.getStoredBlock(BlocksMap.java:113) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReportedBlock(BlockManager.java:1915) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processAndHandleReportedBlock(BlockManager.java:2698) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addBlock(BlockManager.java:2685) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processIncrementalBlockReport(BlockManager.java:2759) > at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.processIncrementalBlockReport(FSNamesystem.java:5321) > at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReceivedAndDeleted(NameNodeRpcServer.java:1018) > ... > {code} > - expectedLocation can be null. > {code} > 2014-01-09 04:28:35,384 WARN ipc.Server (Server.java:run(2060)) - IPC Server handler 5 on 58333, call org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReport from 127.0.0.1:55583 Call#47 Retry#0: error: java.lang.NullPointerException > java.lang.NullPointerException > at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoUnderConstruction.addReplicaIfNotPresent(BlockInfoUnderConstruction.java:331) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processFirstBlockReport(BlockManager.java:1801) > at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReport(BlockManager.java:1645) > at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReport(NameNodeRpcServer.java:987) > ... > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)