Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2E815101F5 for ; Fri, 24 Jan 2014 18:05:49 +0000 (UTC) Received: (qmail 5250 invoked by uid 500); 24 Jan 2014 18:05:44 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 5218 invoked by uid 500); 24 Jan 2014 18:05:43 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 5119 invoked by uid 99); 24 Jan 2014 18:05:40 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jan 2014 18:05:40 +0000 Date: Fri, 24 Jan 2014 18:05:40 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-5702) FsShell Cli: Add XML based End-to-End test for getfacl and setfacl commands MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881220#comment-13881220 ] Chris Nauroth commented on HDFS-5702: ------------------------------------- Excellent work. Thanks for adding these tests! As mentioned on HDFS-5827, the 2 tests failures are expected, because default ACL handling is not yet implemented in the NameNode (tracked in HDFS-5616). I'm planning on committing the failing tests anyway, which is acceptable as a temporary state while we're isolated on a feature branch. Just a few minor comments: # It looks like {{TestAclCLI#fs}} isn't needed for anything, so let's remove that and the import of {{FileSystem}}. # Let's add 3 more tests: ## getfacl -R ## setfacl -R ## setfacl --set (replacing the whole ACL) After that, I think this will be ready to commit. > FsShell Cli: Add XML based End-to-End test for getfacl and setfacl commands > --------------------------------------------------------------------------- > > Key: HDFS-5702 > URL: https://issues.apache.org/jira/browse/HDFS-5702 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client, namenode, security > Reporter: Vinay > Assignee: Vinay > Attachments: HDFS-5702.patch > > > FsShell Cli: Add XML based End-to-End test for getfacl and setfacl commands -- This message was sent by Atlassian JIRA (v6.1.5#6160)