hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5856) DataNode.checkDiskError might throw NPE
Date Thu, 30 Jan 2014 18:34:08 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Elser updated HDFS-5856:
-----------------------------

       Fix Version/s:     (was: 3.0.0)
    Target Version/s: 3.0.0
              Status: Patch Available  (was: Open)

A patch that checks for a non-null message on the Exception before calling String methods
on that message. Lifted the "network-related" conditional into its own method and added a
quick test to ensure we identify the "network-related" exceptions as intended.

> DataNode.checkDiskError might throw NPE
> ---------------------------------------
>
>                 Key: HDFS-5856
>                 URL: https://issues.apache.org/jira/browse/HDFS-5856
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.2.0
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>         Attachments: HDFS-5856.diff
>
>
> Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that
when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError.
> Looking at the code, if the Exception that is handed to checkDiskError contains a null
message, the checks that try to identify if the Exception is network-related will throw a
NPE.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message