hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5797) Implement offline image viewer.
Date Mon, 27 Jan 2014 19:46:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883180#comment-13883180
] 

Jing Zhao commented on HDFS-5797:
---------------------------------

I've tested this patch and looks like a new oiv can work now. Some comments:
# The new FSImageUtil will add another util class for fsimage. Looks like we need to do some
code refactoring here. But since we will finally need to remove all the old saver classes/methods,
I think we can do it there.
# The lsr part will cost memory. I guess we can create a separate jira in the future to improve
it.

Thus I think we can commit this patch first and address the remaining issues later. +1

> Implement offline image viewer.
> -------------------------------
>
>                 Key: HDFS-5797
>                 URL: https://issues.apache.org/jira/browse/HDFS-5797
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>             Fix For: HDFS-5698 (FSImage in protobuf)
>
>         Attachments: HDFS-5797.000.patch, HDFS-5797.001.patch
>
>
> The format of FSImage has changed dramatically therefore a new implementation of OfflineImageViewer
is required.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message