hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5781) Use a map to record the mapping between FSEditLogOpCode and the corresponding byte value
Date Wed, 22 Jan 2014 00:08:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878050#comment-13878050
] 

Hadoop QA commented on HDFS-5781:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12624192/HDFS-5781.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5927//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5927//console

This message is automatically generated.

> Use a map to record the mapping between FSEditLogOpCode and the corresponding byte value
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-5781
>                 URL: https://issues.apache.org/jira/browse/HDFS-5781
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.4.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-5781.000.patch, HDFS-5781.001.patch
>
>
> HDFS-5674 uses Enum.values and enum.ordinal to identify an editlog op for a given byte
value. While improving the efficiency, it may cause issue. E.g., when several new editlog
ops are added to trunk around the same time (for several different new features), it is hard
to backport the editlog ops with larger byte values to branch-2 before those with smaller
values, since there will be gaps in the byte values of the enum. 
> This jira plans to still use a map to record the mapping between editlog ops and their
byte values. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message