hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5747) BlocksMap.getStoredBlock(..) and BlockInfoUnderConstruction.addReplicaIfNotPresent(..) may throw NullPointerException
Date Thu, 09 Jan 2014 23:15:51 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867256#comment-13867256
] 

Jing Zhao commented on HDFS-5747:
---------------------------------

The analysis for the root cause of NPE makes sense to me. +1 for the patch.
Besides we may also want to keep running the unit test overnight to make sure NPE is gone.

> BlocksMap.getStoredBlock(..) and BlockInfoUnderConstruction.addReplicaIfNotPresent(..)
may throw NullPointerException
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5747
>                 URL: https://issues.apache.org/jira/browse/HDFS-5747
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-5747.01.patch
>
>
> Found these NPEs in [build #5849|https://builds.apache.org/job/PreCommit-HDFS-Build/5849//testReport/org.apache.hadoop.hdfs/TestPersistBlocks/TestRestartDfsWithFlush/].
> - BlocksMap is accessed after close:
> {code}
> 2014-01-09 04:28:32,350 WARN  ipc.Server (Server.java:run(2060)) - IPC Server handler
2 on 58333, call org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReceivedAndDeleted
from 127.0.0.1:55572 Call#32 Retry#0: error: java.lang.NullPointerException
> java.lang.NullPointerException
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.getStoredBlock(BlocksMap.java:113)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReportedBlock(BlockManager.java:1915)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processAndHandleReportedBlock(BlockManager.java:2698)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addBlock(BlockManager.java:2685)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processIncrementalBlockReport(BlockManager.java:2759)
> 	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.processIncrementalBlockReport(FSNamesystem.java:5321)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReceivedAndDeleted(NameNodeRpcServer.java:1018)
> 	...
> {code}
> - expectedLocation can be null.
> {code}
> 2014-01-09 04:28:35,384 WARN  ipc.Server (Server.java:run(2060)) - IPC Server handler
5 on 58333, call org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReport from
127.0.0.1:55583 Call#47 Retry#0: error: java.lang.NullPointerException
> java.lang.NullPointerException
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoUnderConstruction.addReplicaIfNotPresent(BlockInfoUnderConstruction.java:331)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processFirstBlockReport(BlockManager.java:1801)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReport(BlockManager.java:1645)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReport(NameNodeRpcServer.java:987)
> 	...
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message