hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5739) ACL RPC must allow null name or null permissions in ACL entries.
Date Wed, 08 Jan 2014 22:28:50 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HDFS-5739:
--------------------------------

    Attachment: HDFS-5739.2.patch

Thanks for the review, Haohui.  I'm attaching patch version 2 to show what this looks like
when we keep permissions required.

bq. Is it possible to simply ignore the value in removeAclEntries?

Yes, the logic currently ignores it.  If we wanted to strictly match existing implementations
like Linux, then we would actually send an error back to the user if they tried to specify
permissions in a remove call.  I don't know that we need to be rigid about that, and we could
always choose to implement that check at the CLI layer if we want it, so I'm fine with this
approach.

The effect of this is that protobuf will default initialize the enum field to the 0'th element
(NONE) on conversion from proto to model.  For symmetry, this patch adds the corresponding
logic in the conversion from model to proto too.

> ACL RPC must allow null name or null permissions in ACL entries.
> ----------------------------------------------------------------
>
>                 Key: HDFS-5739
>                 URL: https://issues.apache.org/jira/browse/HDFS-5739
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client, namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5739.1.patch, HDFS-5739.2.patch
>
>
> Currently, the ACL RPC defines ACL entries with required fields for name and permissions.
 These fields actually need to be optional.  The name can be null to represent unnamed ACL
entries, such as the file owner or mask.  Permissions can be null when passed in an ACL spec
to remove ACL entries via {{FileSystem#removeAclEntries}}.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message