hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5721) sharedEditsImage in Namenode#initializeSharedEdits() should be closed before method returns
Date Thu, 09 Jan 2014 04:24:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866305#comment-13866305
] 

Junping Du commented on HDFS-5721:
----------------------------------

Agree with Uma that in most cases, the closing streams is only a *nice* to have, so change
this JIRA from bug to improvement.
+1 on v3 patch. Will commit it soon.

> sharedEditsImage in Namenode#initializeSharedEdits() should be closed before method returns
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5721
>                 URL: https://issues.apache.org/jira/browse/HDFS-5721
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: hdfs-5721-v1.txt, hdfs-5721-v2.txt, hdfs-5721-v3.txt
>
>
> At line 901:
> {code}
>       FSImage sharedEditsImage = new FSImage(conf,
>           Lists.<URI>newArrayList(),
>           sharedEditsDirs);
> {code}
> sharedEditsImage is not closed before the method returns.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message