hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5709) Improve upgrade with existing files and directories named ".snapshot"
Date Tue, 21 Jan 2014 19:27:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877771#comment-13877771
] 

Aaron T. Myers commented on HDFS-5709:
--------------------------------------

bq. One of the requirements we considered is, the files should not be renamed silently. Hence
the start up option that a user must pass. This is the same reason why we invented configuration
option as well.

By "silently" I meant without logging anything, not that we shouldn't necessarily do the rename
by default. The question I still have is - why would any user _not_ want to automatically
rename the files? Why would they prefer to have to manually downgrade the software, start
up the cluster, manually find all reserved names, rename them, then re-attempt the upgrade?
This seems strictly inferior to the alternative of automatically renaming and then allowing
the user to manually do the rename afterward.

Suresh - what about the other part of my proposal, i.e. by default perform the rename to the
name you suggested ("<original file name>.<layout_version>.reserved_renamed_after_ugprade"),
but optionally rename to something else? Are you OK with that?

> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
>                 Key: HDFS-5709
>                 URL: https://issues.apache.org/jira/browse/HDFS-5709
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: snapshots, upgrade
>         Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch, hdfs-5709-4.patch,
hdfs-5709-5.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer to a directory
named ".snapshot". We should at least print a better error message (which I believe was the
original intention in HDFS-4666), and [~atm] proposed automatically renaming these files and
directories.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message