[ https://issues.apache.org/jira/browse/HDFS-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881220#comment-13881220
]
Chris Nauroth commented on HDFS-5702:
-------------------------------------
Excellent work. Thanks for adding these tests! As mentioned on HDFS-5827, the 2 tests failures
are expected, because default ACL handling is not yet implemented in the NameNode (tracked
in HDFS-5616). I'm planning on committing the failing tests anyway, which is acceptable as
a temporary state while we're isolated on a feature branch.
Just a few minor comments:
# It looks like {{TestAclCLI#fs}} isn't needed for anything, so let's remove that and the
import of {{FileSystem}}.
# Let's add 3 more tests:
## getfacl -R
## setfacl -R
## setfacl --set (replacing the whole ACL)
After that, I think this will be ready to commit.
> FsShell Cli: Add XML based End-to-End test for getfacl and setfacl commands
> ---------------------------------------------------------------------------
>
> Key: HDFS-5702
> URL: https://issues.apache.org/jira/browse/HDFS-5702
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode, security
> Reporter: Vinay
> Assignee: Vinay
> Attachments: HDFS-5702.patch
>
>
> FsShell Cli: Add XML based End-to-End test for getfacl and setfacl commands
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
|