hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5614) NameNode: implement handling of ACLs in combination with snapshots.
Date Fri, 31 Jan 2014 19:46:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888077#comment-13888077

Jing Zhao commented on HDFS-5614:

The v2 patch looks great to me. Just some minors:
# Not related to this patch, shall we also use INodeWithAdditionalFields#getFeature for INodeDirectory#getDirectoryxxxFeature?
# MiniDFSCluster#getFileSystem returns DistributedFileSystem, thus we do not need the following
+    FileSystem fs = cluster.getFileSystem();
+    assertTrue(fs instanceof DistributedFileSystem);
+    hdfs = (DistributedFileSystem)fs;
# In the INodeDirectory constructor INodeDirectory(INodeDirectory other, boolean adopt, boolean
copyFeatures), since we want to copy the acl feature (and maybe some other features in future),
how about defining a constructor like INodeDirectory(INodeDirectory other, boolean adopt,
Feature...featuresToCopy) ?

> NameNode: implement handling of ACLs in combination with snapshots.
> -------------------------------------------------------------------
>                 Key: HDFS-5614
>                 URL: https://issues.apache.org/jira/browse/HDFS-5614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5614.1.patch, HDFS-5614.2.patch
> Within a snapshot, all ACLs are frozen at the moment that the snapshot was created. 
ACL changes in the parent of the snapshot are not applied to the snapshot.

This message was sent by Atlassian JIRA

View raw message