hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4922) Improve the short-circuit document
Date Tue, 14 Jan 2014 05:18:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870400#comment-13870400
] 

Akira AJISAKA commented on HDFS-4922:
-------------------------------------

Thanks for updating! Minor comment:
{code}
+  Local block reader maintains a chunk buffer, This controls the maximum chunks
+  can be filled in the chunk buffer for each read.
+  The buffer size was specified in bytes, but
+  It would be better to be integral multiple of "dfs.bytes-per-checksum"
{code}
Some capital letters can be converted to small. Below fix is good to me.
{code}
+  Local block reader maintains a chunk buffer, this controls the maximum chunks
+  can be filled in the chunk buffer for each read.
+  The buffer size was specified in bytes. It would be better to be integral
+  multiple of "dfs.bytes-per-checksum" for better performance.
{code}
Also, now these parameters are not described in hdfs-default.xml. Would you add them?

> Improve the short-circuit document
> ----------------------------------
>
>                 Key: HDFS-4922
>                 URL: https://issues.apache.org/jira/browse/HDFS-4922
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: documentation, hdfs-client
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Fengdong Yu
>            Assignee: Fengdong Yu
>            Priority: Minor
>         Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922-004.patch, HDFS-4922-005.patch,
HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in the document,
but exists in the code.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message