Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 16 Dec 2013 13:29:09 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12682344.1386063870978.42608.1387200549944@arcas>
In-Reply-To: <JIRA.12682344.1386063870978@arcas>
References: <JIRA.12682344.1386063870978@arcas>
Subject: [jira] [Commented] (HDFS-5592) "DIR* completeFile: /file is closed
 by DFSClient_" should be logged only for successful closure of the file.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849147#comment-13849147 ] 

Hudson commented on HDFS-5592:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk #1614 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1614/])
HDFS-5592. statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java


> "DIR* completeFile: /file is closed by DFSClient_" should be logged only for successful closure of the file.
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5592
>                 URL: https://issues.apache.org/jira/browse/HDFS-5592
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Vinay
>            Assignee: Vinay
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: HDFS-5592.patch
>
>
> Following log message in {{FSNameSystem#completeFile(..)}} should be logged only if the file is closed.
> {code}    getEditLog().logSync();
>     NameNode.stateChangeLog.info("DIR* completeFile: " + src + " is closed by "
>         + holder);
>     return success;{code}


--
This message was sent by Atlassian JIRA
(v6.1.4#6159)