Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8A9AA10127 for ; Thu, 26 Dec 2013 05:33:00 +0000 (UTC) Received: (qmail 98416 invoked by uid 500); 26 Dec 2013 05:32:53 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 98371 invoked by uid 500); 26 Dec 2013 05:32:52 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 98331 invoked by uid 99); 26 Dec 2013 05:32:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Dec 2013 05:32:52 +0000 Date: Thu, 26 Dec 2013 05:32:52 +0000 (UTC) From: "sathish (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-5582) hdfs getconf -excludeFile or -includeFile always failed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5582?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] sathish updated HDFS-5582: -------------------------- Attachment: 0002-HDFS-5582.patch Thanks Andrew wang for having a look,updating the patch as per the comments= with unit test case > hdfs getconf -excludeFile or -includeFile always failed > ------------------------------------------------------- > > Key: HDFS-5582 > URL: https://issues.apache.org/jira/browse/HDFS-5582 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.1.0-beta, 2.2.0, 2.3.0 > Reporter: Henry Hung > Assignee: sathish > Priority: Minor > Attachments: 00001-HDFS-5582.patch, 0002-HDFS-5582.patch > > > In hadoop-2.2.0, if you execute getconf for exclude and include file, it = will return this error message: > {code} > [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -excludeFile > Configuration DFSConfigKeys.DFS_HOSTS_EXCLUDE is missing. > [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -includeFile > Configuration DFSConfigKeys.DFS_HOSTS is missing. > {code} > I found out the root cause is very simple, it=E2=80=99s because the sourc= e code of {{org/apache/hadoop/hdfs/tools/GetConf.java}} hard coded it to {{= "DFSConfigKeys.DFS_HOSTS"}} and {{"DFSConfigKeys.DFS_HOSTS_EXCLUDE"}} > {code} > map.put(INCLUDE_FILE.getName().toLowerCase(),=20 > new CommandHandler("DFSConfigKeys.DFS_HOSTS")); > map.put(EXCLUDE_FILE.getName().toLowerCase(), > new CommandHandler("DFSConfigKeys.DFS_HOSTS_EXCLUDE")); > {code} > A simple fix would be to remove the quote: > {code} > map.put(INCLUDE_FILE.getName().toLowerCase(),=20 > new CommandHandler(DFSConfigKeys.DFS_HOSTS)); > map.put(EXCLUDE_FILE.getName().toLowerCase(), > new CommandHandler(DFSConfigKeys.DFS_HOSTS_EXCLUDE)); > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)