hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5701) Fix the CacheAdmin -addPool -maxTtl option name
Date Fri, 27 Dec 2013 00:17:50 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857182#comment-13857182
] 

Hadoop QA commented on HDFS-5701:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12620554/HDFS-5701.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.TestBackupNode
                  org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5794//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5794//console

This message is automatically generated.

> Fix the CacheAdmin -addPool -maxTtl option name
> -----------------------------------------------
>
>                 Key: HDFS-5701
>                 URL: https://issues.apache.org/jira/browse/HDFS-5701
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: caching, tools
>    Affects Versions: 3.0.0
>            Reporter: Stephen Chu
>            Assignee: Stephen Chu
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HDFS-5701.patch
>
>
> Currently, the CacheAdmin usage shows the "maxttl" option for -addPool, but the option
should be listed as "maxTtl" instead.
> If users attempt to use "maxttl" they will see the following error:
> {code}
> bash-4.1$ hdfs cacheadmin -addPool pool2 -maxttl 10s
> Can't understand arguments: -maxttl 10s
> Usage is [-addPool <name> [-owner <owner>] [-group <group>] [-mode
<mode>] [-limit <limit>] [-maxttl <maxTtl>]
> {code}
> We should change the usage to usage "maxTtl"



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message