hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5695) Clean up TestOfflineEditsViewer and OfflineEditsViewerHelper
Date Mon, 30 Dec 2013 20:09:50 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859045#comment-13859045
] 

Colin Patrick McCabe commented on HDFS-5695:
--------------------------------------------

{code}
    // judgment time
{code}
while you're improving this, can you fix the spelling here?

I don't understand why the new version lacks {{TestOfflineEditsViewer#testStored}}.  That
seems like it would reduce test coverage.

> Clean up TestOfflineEditsViewer and OfflineEditsViewerHelper
> ------------------------------------------------------------
>
>                 Key: HDFS-5695
>                 URL: https://issues.apache.org/jira/browse/HDFS-5695
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5695.000.patch
>
>
> TestOfflineEditsViewer and OfflineEditsViewerHelper duplicate some of the functionality
available in DFSTestUtil. The code can be simplified.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message