hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5689) FsDatasetImpl registers mbean using uninitialized DataNode UUID
Date Thu, 19 Dec 2013 21:17:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853330#comment-13853330
] 

Hadoop QA commented on HDFS-5689:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12619608/HDFS-5689.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5770//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5770//console

This message is automatically generated.

> FsDatasetImpl registers mbean using uninitialized DataNode UUID
> ---------------------------------------------------------------
>
>                 Key: HDFS-5689
>                 URL: https://issues.apache.org/jira/browse/HDFS-5689
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: David Powell
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HDFS-5689.patch
>
>
> FsDatasetImpl's constructor attempts to include the datanode UUID in its mbean's ObjectName:
>   registerMBean(datanode.getDatanodeUuid());
> Unfortunately this doesn't work because the provided DataNode's UUID isn't set until
bpRegistrationSucceeded() is called... after the FsDatasetImpl has been created.  The result
is the mbean is always registered with a bogus (though valid) ObjectName:
>   Hadoop:name=FSDatasetState-null,service=DataNode
> Prior to HDFS-2832 and the storageID -> datanodeUuid rename, this was initialized
using the DataStorage:
>   registerMBean(storage.getStorageID());
> With the fix for HDFS-5454 in place, doing equivalent thing (already done by SimulatedFSDataset):
>   registerMBean(storage.getDatanodeUuid());
> ...fixes the problem:
>   Hadoop:name=FSDatasetState-24aed86a-fee6-4b88-868e-285e09ea2766,service=DataNode



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message