hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5676) fix inconsistent synchronization of CachingStrategy
Date Wed, 18 Dec 2013 19:49:07 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Colin Patrick McCabe updated HDFS-5676:

    Attachment: HDFS-5676.003.patch

yeah, I think this is a case where AtomicReference is simpler.  I fixed the javadoc and added
some comments about AtomicReference.  reposting

> fix inconsistent synchronization of CachingStrategy
> ---------------------------------------------------
>                 Key: HDFS-5676
>                 URL: https://issues.apache.org/jira/browse/HDFS-5676
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-5676.001.patch, HDFS-5676.003.patch
> Currently, the synchronization for {{CachingStrategy}} is a little inconsistent.  DFSOutputStream#setDropBehind
modifies the strategy object, but there's nothing protecting that object against concurrent
use in {{createBlockOutputStream}}.  Similarly, {{DFSInputStream#setDropBehind}} is synchronized,
but not all the uses of {{cachingStrategy}} are.

This message was sent by Atlassian JIRA

View raw message