hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5674) Editlog code cleanup
Date Tue, 17 Dec 2013 15:18:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850556#comment-13850556
] 

Hadoop QA commented on HDFS-5674:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12619098/h5674_20131217.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5741//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5741//console

This message is automatically generated.

> Editlog code cleanup
> --------------------
>
>                 Key: HDFS-5674
>                 URL: https://issues.apache.org/jira/browse/HDFS-5674
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h5674_20131217.patch
>
>
> A few minor improvements:
> - \@SuppressWarnings("deprecation") in FSEditLogOp can be removed.
> - FSEditLogOpCodes.fromByte(..) can be more efficient.
> - Some fields in FSEditLog can be final.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message